fixes unit tests #2499
Merged
fixes unit tests #2499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(not sure why there's a null turf in that list anyway)
github-actions
bot
added
the
Map Change
Latentish
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
I'd like to tm this to make sure shit doesn't break down, but it looks good. You even went in and fixed the catalogue entries.
I'd prefer if you added a picture of the superpill to your pr, as minor as that is, because you did perform open heart surgery on it live in call so it's enough of a change to show visually.
|
sure, here's the new superpill: |
|
oh my god |
|
what the fuck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Currently ships with subshuttles fail unit tests. This wasn't perfectly clear before, because only ships which were enabled for roundstart spawn were tested by unit tests. This PR fixes both.
Make sure the unit tests on this one actually succeed, since I need to ensure the newly-tested ships don't start failing.
Why It's Good For The Game
better tests are good + makes it OK to merge subshuttle PRs
Changelog
🆑
fix: Ship-spawn unit tests have been fixed and expanded.
/:cl: